| nicolasfella |
| KDE Connect |
KDE app : https://phabricator.kde.org/D12802
For the icon, I created them from the breeze icon of a tv.
I changed the color, the transparency and added rounded corners to match existing icons.
About the translations, I have added a new string to the main strings.xml file.
Is it automatically deployed to translation teams ?
In the coming weeks, I'll try to port the app to Android TV with a specific tv layout.
Tested with an Android TV device (Nvidia Shield)
| No Linters Available |
| No Unit Test Coverage |
Thanks for your work!
I don't own an Android TV, so I can't fully test your work, but just by looking at the code it seems reasonable to me. Maybe one of the other developers can do a full test.
In general, for visible changes it's good practice to attach a screenshot. Have you also tested the look with the dark theme enabled?
About the translation: You did perfectly fine, it will get to the translation team as soon as it is committed.
Thanks for your reviews and tests.
Yes I have commit rights, I will push that soon.
About the icons, the existing ones are a bit different than the desktop app.
Maybe we should think about uniformizing them ?
Here are some screenshots:
(On an Android 8.0 phone)
| Light Mode | Dark mode |
 |  |
(On the Android 7.0 TV, viewing plugin settings for the above phone)
