philipc (Philip Cohn-Cort)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Jan 8 2018, 6:42 PM (130 w, 2 d)
Availability
Available

Recent Activity

Jun 6 2020

philipc committed R225:ee5c75e10aad: Add support for Bigscreen STT using android's inbuilt speech engine (authored by Aiix).
Add support for Bigscreen STT using android's inbuilt speech engine
Jun 6 2020, 9:39 PM

May 24 2020

philipc committed R224:cf2967b9af68: Add Bigscreen plugin with support for Bigscreen STT packet type (authored by Aiix).
Add Bigscreen plugin with support for Bigscreen STT packet type
May 24 2020, 12:13 AM
philipc committed R224:8bf49850f177: use tv icon for bigscreen plugin (authored by Aiix).
use tv icon for bigscreen plugin
May 24 2020, 12:13 AM

May 13 2020

philipc committed R225:787b07b522b0: Bump gradle wrapper version. (authored by abogical).
Bump gradle wrapper version.
May 13 2020, 7:01 AM

May 7 2020

philipc committed R224:cec37a80f839: Remove old references to png icons (authored by philipc).
Remove old references to png icons
May 7 2020, 10:09 PM

Apr 29 2020

philipc committed R225:09a20e8b8e7b: Include git commit in APK filename (authored by philipc).
Include git commit in APK filename
Apr 29 2020, 7:01 PM

Apr 13 2020

philipc committed R224:c315170be5e6: Finally, we have support for sending out Battery information. (authored by philipc).
Finally, we have support for sending out Battery information.
Apr 13 2020, 5:54 AM

Mar 22 2020

philipc committed R225:23337fb2f440: Target and compile against Android 10.0 (SDK 29) (authored by philipc).
Target and compile against Android 10.0 (SDK 29)
Mar 22 2020, 2:46 AM
philipc committed R225:5e0ae437bba8: Upgrade gradle plugin for AS 3.6.1 (authored by philipc).
Upgrade gradle plugin for AS 3.6.1
Mar 22 2020, 2:46 AM
philipc committed R225:51b5989183dc: Request v10.2.1 of the butterknife runtime dependency (authored by philipc).
Request v10.2.1 of the butterknife runtime dependency
Mar 22 2020, 2:46 AM
philipc committed R225:7e935a495ebf: Remove old protocol v6 code from DeviceTest.java (authored by philipc).
Remove old protocol v6 code from DeviceTest.java
Mar 22 2020, 2:46 AM
philipc committed R225:2c4274ed2a10: Update gradle wrapper files to match those bundled w/ 5.4.1 (authored by philipc).
Update gradle wrapper files to match those bundled w/ 5.4.1
Mar 22 2020, 2:46 AM
philipc committed R225:06a73ca8569c: Use gradle.properties to control what kind of code optimization runs (authored by philipc).
Use gradle.properties to control what kind of code optimization runs
Mar 22 2020, 2:46 AM

Sep 7 2019

philipc committed R225:265828aeee29: Try to make the BackgroundJob subclasses javadocs a little easier to understand (authored by philipc).
Try to make the BackgroundJob subclasses javadocs a little easier to understand
Sep 7 2019, 10:49 AM
philipc committed R225:79e4f626056d: Document (in brief) SharePlugin.java, Device.java and BackgroundJobHandler.java (authored by philipc).
Document (in brief) SharePlugin.java, Device.java and BackgroundJobHandler.java
Sep 7 2019, 10:49 AM
philipc committed R225:83e084a7129d: Document part of each of the two BackgroundJob subclasses (authored by philipc).
Document part of each of the two BackgroundJob subclasses
Sep 7 2019, 10:49 AM
philipc committed R225:9937be47919e: Add threading annotations to various ::sendPacket methods (authored by philipc).
Add threading annotations to various ::sendPacket methods
Sep 7 2019, 10:49 AM

May 17 2018

philipc added inline comments to D9690: Add contacts-reading plugin (Android side).
May 17 2018, 6:01 PM · KDE Connect

May 11 2018

philipc added a comment to D12803: Add detection of Android TV devices with a proper icon.

Here are some screenshots:

May 11 2018, 6:11 AM · KDE Connect

May 9 2018

philipc accepted D12229: Use lambdas where possible.

Perfect!

May 9 2018, 1:35 AM · KDE Connect

Apr 29 2018

philipc added a comment to D12229: Use lambdas where possible.

It looks pretty good to me - it should be fully compatible with all of our users as per google's docs on the matter. Just needs to be rebased on master.

Apr 29 2018, 10:25 PM · KDE Connect

Apr 27 2018

philipc accepted D12501: Bump gradle version.

Anyway, I think this change is good enough for now. We can revisit the version later.

Apr 27 2018, 12:39 AM · KDE Connect

Apr 26 2018

philipc added a comment to D12501: Bump gradle version.

I wonder; if we're updating the gradle plugin version, shouldn't we go to the latest stable version 3.1.2?

That sound reasoable. I merely did what Android Studio suggested to me. Maybe it didn't suggest the latest version because Android Studio itself is not up-to-date (I've installed from flathub and apparently the newest version isn't there yet)

Apr 26 2018, 1:32 AM · KDE Connect

Apr 24 2018

philipc added a comment to D12501: Bump gradle version.

I wonder; if we're updating the gradle plugin version, shouldn't we go to the latest stable version 3.1.2?

Apr 24 2018, 7:29 PM · KDE Connect

Apr 23 2018

philipc added a comment to D11694: Add a dark theme.

I'm afraid I don't.

Apr 23 2018, 3:37 PM · KDE Connect

Apr 21 2018

philipc added a comment to D11694: Add a dark theme.

Screenshots from Android 7.1 device:

Apr 21 2018, 3:32 AM · KDE Connect
philipc updated the diff for D11694: Add a dark theme.

@mtijink I tried to take account of your suggestions. The toolbar and statusbar
now match the colors @nicolasfella proposed, and we have a light grey for the
drawer to establish contrast. I'll upload a screenshot or two as well.

Apr 21 2018, 3:04 AM · KDE Connect

Apr 19 2018

philipc added a comment to D11694: Add a dark theme.

By all means. Sorry for not being more on top of the revision.

Apr 19 2018, 2:54 PM · KDE Connect

Apr 15 2018

philipc updated the diff for D11694: Add a dark theme.

Use true black (no code changes, just fixing commit history)

Apr 15 2018, 3:42 AM · KDE Connect

Apr 14 2018

philipc added a comment to D11694: Add a dark theme.

....and I seem to have lost the commit history

Apr 14 2018, 6:25 PM · KDE Connect
philipc updated the diff for D11694: Add a dark theme.

Use true black for window backgrounds, and two darker oranges for the toolbar (0x612e00) and statusbar (0x502600).

Apr 14 2018, 6:24 PM · KDE Connect

Apr 8 2018

philipc added a comment to D11694: Add a dark theme.

The icon used for 'Send files' is atypical - all of the other drawables are at least partially transparent, while that one is opaque. We should probably replace it with a more appropriate asset, possibly in a future change to vector assets.

Apr 8 2018, 8:23 PM · KDE Connect

Mar 29 2018

philipc updated the diff for D11694: Add a dark theme.

Include previously-omitted parts of the patch

Mar 29 2018, 7:51 PM · KDE Connect
philipc added a comment to D11694: Add a dark theme.

Ugh. I'm just not used to arcanist....let me try again.

Mar 29 2018, 7:50 PM · KDE Connect

Mar 28 2018

philipc updated the diff for D11694: Add a dark theme.

This should address the pieces I had overlooked (thanks Matthijs!)

Mar 28 2018, 4:47 PM · KDE Connect

Mar 25 2018

philipc retitled D11694: Add a dark theme from Use theme attributes for appearance of activity_main.xml to Add a dark theme.
Mar 25 2018, 6:57 PM · KDE Connect
philipc requested review of D11694: Add a dark theme.
Mar 25 2018, 6:32 PM · KDE Connect
philipc claimed T7044: Dark Mode & Settings.

I'll work on the dark mode feature.

Mar 25 2018, 11:34 AM · KDE Connect
philipc requested review of D11672: Add method documentation to LanLinkProvider.java.
Mar 25 2018, 9:46 AM · KDE Connect

Mar 24 2018

philipc requested review of D11648: Only make one request for list of MPRIS players during plugin creation.
Mar 24 2018, 4:14 PM
philipc requested review of D11645: Use simpler syntax for Google Maven repository.
Mar 24 2018, 2:15 PM

Jan 20 2018

philipc added inline comments to D7959: Make it possible to add commands for the RunCommandsPlugin from Android.
Jan 20 2018, 2:54 AM · KDE Connect