Add detection of Android TV devices with a proper icon
ClosedPublic

Authored by laissus on May 10 2018, 11:23 AM.

Details

Summary

KDE app : https://phabricator.kde.org/D12802

For the icon, I created them from the breeze icon of a tv.
I changed the color, the transparency and added rounded corners to match existing icons.

About the translations, I have added a new string to the main strings.xml file.
Is it automatically deployed to translation teams ?

In the coming weeks, I'll try to port the app to Android TV with a specific tv layout.

Test Plan

Tested with an Android TV device (Nvidia Shield)

Diff Detail

Repository
R225 KDE Connect - Android application
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
laissus created this revision.May 10 2018, 11:23 AM
Restricted Application added a project: KDE Connect. · View Herald TranscriptMay 10 2018, 11:23 AM
Restricted Application added a subscriber: kdeconnect. · View Herald Transcript
laissus requested review of this revision.May 10 2018, 11:23 AM
laissus edited the summary of this revision. (Show Details)May 10 2018, 11:27 AM
laissus added a reviewer: KDE Connect.
laissus edited the summary of this revision. (Show Details)
laissus edited the summary of this revision. (Show Details)May 10 2018, 11:30 AM

Thanks for your work!

I don't own an Android TV, so I can't fully test your work, but just by looking at the code it seems reasonable to me. Maybe one of the other developers can do a full test.
In general, for visible changes it's good practice to attach a screenshot. Have you also tested the look with the dark theme enabled?

About the translation: You did perfectly fine, it will get to the translation team as soon as it is committed.

tfella added a subscriber: tfella.May 10 2018, 1:32 PM

Seems to work fine using Android TV on a raspberry pi

nicolasfella accepted this revision.May 10 2018, 1:40 PM

Do you have commit rights?

This revision is now accepted and ready to land.May 10 2018, 1:40 PM

Can we use the svg icons from the desktop here?

Thanks for your reviews and tests.
Yes I have commit rights, I will push that soon.

About the icons, the existing ones are a bit different than the desktop app.
Maybe we should think about uniformizing them ?

This revision was automatically updated to reflect the committed changes.

Here are some screenshots:

(On an Android 8.0 phone)

Light ModeDark mode

(On the Android 7.0 TV, viewing plugin settings for the above phone)