Differential D12802

Add detection of Android TV devices with a proper icon
ClosedPublic
Actions

Authored by laissus on May 10 2018, 11:18 AM.

Details

Reviewers

nicolasfella

Group Reviewers

KDE Connect

Commits

R224:c6ebdbe89bd6: Add detection of Android TV devices with a proper icon

Summary

Android app : https://phabricator.kde.org/D12803

I created the icons based on the tv icon of breeze with my basic design skills.
I changed the colors and the transparency to match existing icons. Is it ok ?

Test Plan

Tested with an Android TV device (Nvidia Shield)

Diff Detail

Repository

R224 KDE Connect

Branch

android_tv_detection

Lint

No Linters Available

Unit

No Unit Test Coverage

laissus created this revision.May 10 2018, 11:18 AM

Restricted Application added a project: KDE Connect. · View Herald TranscriptMay 10 2018, 11:18 AM

Restricted Application added a subscriber: kdeconnect. · View Herald Transcript

laissus requested review of this revision.May 10 2018, 11:18 AM

laissus edited the summary of this revision. (Show Details)May 10 2018, 11:21 AM

laissus edited the test plan for this revision. (Show Details)

laissus added a reviewer: KDE Connect.

laissus edited the summary of this revision. (Show Details)May 10 2018, 11:29 AM

nicolasfella accepted this revision.May 10 2018, 3:26 PM

This revision is now accepted and ready to land.May 10 2018, 3:26 PM

Closed by commit R224:c6ebdbe89bd6: Add detection of Android TV devices with a proper icon (authored by laissus). · Explain WhyMay 10 2018, 3:57 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path
M			core/device.h (1 line)
M			core/device.cpp (2 lines)
A	M	(img)	icon/32-status-tvconnected.png
A	M	(img)	icon/32-status-tvdisconnected.png
A	M	(img)	icon/32-status-tvtrusted.png
M			icon/CMakeLists.txt (6 lines)
A	M		icon/sc-status-tvconnected.svg (124 lines)
A	M		icon/sc-status-tvdisconnected.svg (106 lines)
A	M		icon/sc-status-tvtrusted.svg (111 lines)