Differential D12798

Constrain libsmbclient bug workaround to affected versions only
ClosedPublic
Actions

Authored by madcatx on May 10 2018, 8:30 AM.

Details

Reviewers
elvisangelaccio
ngraham
Commits
R320:6529d29166ac: Constrain libsmbclient bug workaround to affected versions only
Summary

A bug where libsmbclient returned nonsensical error code which prevented kio_smb plugin to query user for login credentials appears to have been fixed in Samba 4.7.7 and Samba 4.8.0. Constrain the workaround for the problem only to affected version of libsmbclient.

Samba 4.7.7 release notes: https://www.samba.org/samba/history/samba-4.7.7.html
Relevant bug report: https://bugzilla.samba.org/show_bug.cgi?id=13050

CCBUG: 390551

Diff Detail

Repository
R320 KIO Extras
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
madcatx requested review of this revision.May 10 2018, 8:30 AM
madcatx created this revision.
ngraham accepted this revision.May 10 2018, 1:00 PM

Ah perfect, I was actually just about to submit the exact same patch! Needless to say, works for me.

This revision is now accepted and ready to land.May 10 2018, 1:00 PM
ngraham edited the summary of this revision. (Show Details)May 10 2018, 1:03 PM
elvisangelaccio accepted this revision.May 10 2018, 8:37 PM
madcatx added a comment.May 11 2018, 9:29 AM

Thanks. Can you commit this for me as I don't have commit rights?

Closed by commit R320:6529d29166ac: Constrain libsmbclient bug workaround to affected versions only (authored by madcatx, committed by ngraham). · Explain WhyMay 11 2018, 1:58 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msmb/kio_smb.cpp (2 lines)

Diff 33990

View Options

smb/kio_smb.cpp

Loading...