Improve single-instance application behavior
ClosedPublic
Actions

Authored by volkov on May 8 2018, 4:00 PM.

Details

Reviewers

mart

Group Reviewers

Plasma

Commits

Summary

Avoid showing the window of the second instance by creating KDBusService object before creating the window object.
Activate the window on the second start.

Repository

R102 KInfoCenter

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

volkov requested review of this revision.May 8 2018, 4:00 PM

mart added inline comments.

main.cpp
71	KWindowSystem::forceActiveWindow should never be used by normal applications, it's reserved for workspaces and won't work on Wayland. QWidget::activateWindow should be enough, even if that's not guaranteed to actually raise the window, is more correct.

This comment was removed by volkov.

main.cpp
71	The documentation of KDBusService recommends to use it: https://api.kde.org/frameworks/kdbusaddons/html/classKDBusService.html#af0ad38f597aedaf22a30045d0423ed0e And many applications do it: https://lxr.kde.org/search?_filestring=&_string=forceActiveWindow

This revision is now accepted and ready to land.May 16 2018, 10:18 AM

			Path	Packages
M			CMakeLists.txt (2 lines)
M			main.cpp (7 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	33830	e38d60f		May 8 2018, 4:00 PM	★	★