Make some strings easier to translate
ClosedPublic

Authored by aacid on May 5 2018, 10:52 PM.

Details

Summary

Some strings in ksysguard use this advanced feature of being actually
multiple strings separated by "\xc2\x9c" and then letting the UI use one
or another depending how much space is available.

This is a cool feature, but until this patch it was made in a way the
translatable strings actually contained "\xc2\x9c" that makes it
hard to translate correctly since it's not a trivial character to input.

With this patch I have splitted the character out of the translatable
strings

Test Plan

Works

Diff Detail

Repository
R106 KSysguard
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
aacid created this revision.May 5 2018, 10:52 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMay 5 2018, 10:52 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
aacid requested review of this revision.May 5 2018, 10:52 PM
mart accepted this revision.May 11 2018, 9:40 AM
mart added a subscriber: mart.
mart added inline comments.
gui/SensorDisplayLib/FancyPlotter.cpp
597

maybe it's worth to have an i18nc here or it looks pretty mysterious?

This revision is now accepted and ready to land.May 11 2018, 9:40 AM
aacid added inline comments.May 14 2018, 11:10 PM
gui/SensorDisplayLib/FancyPlotter.cpp
597

Problem is i don't really understand what lastValue and mlotter->valueAsString are supposed to be 😃

But the nice thing is that at least the message won't be worse than it was.

aacid closed this revision.May 14 2018, 11:11 PM