Differential D12561

Set central splitter to non collapsible
ClosedPublic
Actions

Authored by muhlenpfordt on Apr 27 2018, 7:24 AM.

Details

Reviewers
huoni
Group Reviewers
Gwenview
Commits
R260:1ba6572de4b1: Set central splitter to non collapsible
Summary

The sidebar can be toggled by F4, View → Sidebar or
a button in the status bar. Hiding the sidebar by dragging the
central splitter to a collapsed state may confuse users if they
can't toggle the sidebar anymore using the normal ways.
This gets even more awkward saving the splitter state in D12489.
This patch simply disables collapsing for the central splitter.

FIXED-IN: 18.08.0

Test Plan
  • Open Gwenview with visible sidebar
  • Move the horizontal splitter left and right
  • It should not be possible to collapse one side

Diff Detail

Repository
R260 Gwenview
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
muhlenpfordt requested review of this revision.Apr 27 2018, 7:24 AM
muhlenpfordt created this revision.
muhlenpfordt added a dependent revision: D12489: Remember width of sidebar.
huoni accepted this revision.Apr 27 2018, 8:02 AM

Easy review :)
Works as advertised, and code in apropriate place.

This revision is now accepted and ready to land.Apr 27 2018, 8:02 AM
Closed by commit R260:1ba6572de4b1: Set central splitter to non collapsible (authored by muhlenpfordt). · Explain WhyApr 30 2018, 11:21 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mapp/mainwindow.cpp (1 line)

Diff 33319

View Options

app/mainwindow.cpp

Loading...