Fix overlapping warning widget
AbandonedPublic

Authored by hindenburg on Apr 25 2018, 5:43 PM.

Details

Reviewers
anemeth
Group Reviewers
Konsole
VDG
Summary

The warning widget was floating around aimlessly overlapping elements. Now it has a fixed place.

Test Plan

Before:

After:

Diff Detail

Repository
R319 Konsole
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
anemeth created this revision.Apr 25 2018, 5:43 PM
Restricted Application added a project: Konsole. · View Herald TranscriptApr 25 2018, 5:43 PM
Restricted Application added a subscriber: Konsole. · View Herald Transcript
anemeth requested review of this revision.Apr 25 2018, 5:43 PM
anemeth updated this revision to Diff 33092.Apr 25 2018, 5:53 PM

Redo UI change

anemeth edited the summary of this revision. (Show Details)Apr 25 2018, 5:55 PM
anemeth edited the test plan for this revision. (Show Details)
anemeth added reviewers: Konsole, VDG.

Thanks for bringing this up - I'll give it a look; designer has a bad habit of changing more than needed. I wonder if adding a notice in the profile name box would be simpler.

Restricted Application added a subscriber: konsole-devel. · View Herald TranscriptMay 13 2018, 10:59 PM

Unless someone objects, I'm going to remove this warning and just use the QLineEdit's placeholderText

_ui->profileNameEdit->setPlaceholderText(i18n("A profile name must be entered!"));

Are we sure that would have enough visibility to avoid being missed?

That crossed my mind that it would be nice to have a red border/background but that doesn't appear simple to do. Regardless, you can't apply/save w/o a name; there's popup dialogs if you try.

hindenburg commandeered this revision.May 21 2018, 9:46 PM
hindenburg added a reviewer: anemeth.

I'm abandoning this - I'll commit the changes to use setPlaceholderText

hindenburg abandoned this revision.May 21 2018, 9:46 PM