QML applets need to manage padding by themselves
ClosedPublic
Actions

Authored by mart on Apr 25 2018, 12:42 PM.

Details

Reviewers

hein

Group Reviewers

Plasma

Commits

Summary

remove our padding from qml kcms
this fixes the cutted away shadow for InlineMessage

Test Plan

InlineMessages work better now

Repository

R124 System Settings

Branch

phab/externalpadding

Lint

No Linters Available

Unit

No Unit Test Coverage

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

mart requested review of this revision.Apr 25 2018, 12:42 PM

What does this look like now?

Same as before, we're just refactoring to clean some code :)

This revision is now accepted and ready to land.Apr 26 2018, 10:39 AM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			core/ModuleView.cpp (15 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	33061	2b158ac		Apr 25 2018, 12:42 PM	★	★
Diff 2	33110	2b158ac	- use pixelmetrics from the style for the padding	Apr 25 2018, 10:21 PM	★	★
Diff 3	33142	c39152a	R124:6a9df821ecfaa008206a260b20f595136e254821	Apr 26 2018, 11:07 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
e9d241ae293c	abef9534ed52	9ded5a892d8b	Marco Martin	use pixelmetrics from the style for the padding	Apr 25 2018, 10:20 PM
9ded5a892d8b	3e111029ef6f	2b158ac36aa6	Marco Martin	QML applets need to manage padding by themselves (Show More…)	Apr 25 2018, 12:36 PM