Differential D12439

Add EventDataDecorator::hasEndDateTime()
AbandonedPublic
Actions

Authored by kossebau on Apr 22 2018, 10:42 AM.

Details

Reviewers
None
Group Reviewers
Plasma
Summary

There can be events which have no duration. Those are represented by having
a start datetime, but no valid end dateTime.
The new method hasEndDateTime() simplifies querying this from QML.

Follows the API of KCalCore::Event.

Diff Detail

Repository
R242 Plasma Framework (Library)
Branch
addhasEndDateTime
Lint
No Linters Available
Unit
No Unit Test Coverage
kossebau created this revision.Apr 22 2018, 10:42 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptApr 22 2018, 10:42 AM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript
kossebau requested review of this revision.Apr 22 2018, 10:42 AM
broulik added a subscriber: broulik.May 2 2018, 12:15 PM

!isNaN(endDateTime.getTime())?

kossebau abandoned this revision.May 2 2018, 12:39 PM

Seems code out there is already relying on !isNaN(datetime) so let's do the same for now. Besides, there can be events with also only end-date, so the same check would be needed for the start date, thus this API would be incomplete.

Revision Contents
Changeset List

Diff 32783

View Options

src/declarativeimports/calendar/eventdatadecorator.h

Loading...
View Options

src/declarativeimports/calendar/eventdatadecorator.cpp

Loading...