Differential D1242

Guard round this delegate getting deleted during menu exec
ClosedPublic
Actions

Authored by davidedmundson on Mar 28 2016, 11:59 PM.

Details

Reviewers
mart
Group Reviewers
Plasma
Commits
R119:b7faa415a404: Guard round this delegate getting deleted during menu exec
Summary

BUG: 360711

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson updated this revision to Diff 2988.Mar 28 2016, 11:59 PM
davidedmundson retitled this revision from to Guard round this delegate getting deleted during menu exec.
davidedmundson updated this object.
davidedmundson edited the test plan for this revision. (Show Details)
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma. · View Herald TranscriptMar 28 2016, 11:59 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mart accepted this revision.Mar 29 2016, 11:26 AM
mart added a reviewer: mart.
This revision is now accepted and ready to land.Mar 29 2016, 11:26 AM
broulik added a subscriber: broulik.Mar 29 2016, 11:55 AM

Meh, I thought I tested it thorougly when I switched it from QMetaObject invokeMethod to QTimer with lambda :/

applets/taskmanager/plugin/backend.cpp
356

Doesn't this thing need an object to guard?
QPointer<TaskManager::BasicMenu> guard(m_contextMenu)

davidedmundson added inline comments.Mar 29 2016, 5:08 PM
applets/taskmanager/plugin/backend.cpp
356

Good spot! Thanks
(and actually tested properly this time)

Closed by commit R119:b7faa415a404: Guard round this delegate getting deleted during menu exec (authored by davidedmundson). · Explain WhyMar 29 2016, 10:04 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 3018

View Options

applets/taskmanager/plugin/backend.cpp

Loading...