Homogeneized scheduler log strings for clarity when reviewing test results. Warning, all these logs are using i18n, so those changes obviously have an impact on translation, if they are indeed translated.
Reworked job estimation to check the number of light frames for each sequence job in the schedule, in order to consolidate the total number of frames effectively captured without dropping a sequence job by mistake.
Reworked job time estimation to properly account for progress when using repeats. Now repeats-required field is expectedly 1 by default.
Reworked capture count algorithm to rely on the state of the job to execute the search, and reuse previous results whenever possible. This reduces the directory parsing to storages of job which actually changed. Also, this does not handle the duplicate scheduler job situation, only the duplicate sequence job. But possibly we don't care about the duplicate scheduler job situation, that's completely acceptable and so much simpler for the end-user to have two duplicated jobs update to an identical status. BUT the case that is not covered is the situation where the end-user would like to capture a target multiple times, at different times. I believe the option "Remember Job Progress" might provide a solution there, but this is to be tested.
There is still work to be done as jobs won't update their capture count in all situations. This should be fixed with better control of the job's state, not in
this function.
I believe this is still quite slow, less than before but still slow. Perhaps remove all logs from getCompletedFiles.
This change also re-evaluates job in different situations, to get a more reactive and always up-to-date interface. The objective is to never use the "evaluate" button except for really resetting jobs.
Also, added mitigation in the case findNextJob can't decide which job to select.
Fixed zero-job evaluation crash, a regression induced by those changes.
This change also works around issue with job definitely abandoned although they could be rescheduled later, eventually on another night. This also mitigates the issue with altitude cutoff, which apparently can't reliably determine when the target is rising instead of falling.
Also, removed scattered return instructions to clarify the algorithm. When a capture says "Complete", changed the state to "Evaluation" so that job properly recounts its captures and properly considers the work left to be done.
Fixed a few uses of QString::arg(). One call to QString::arg will replace all "%X" in the string. Next call to QString::arg will replace all "%X+1", etc.
A few additional fixes for scheduler jobs logs to use job's date format.
FIXME on attempting to request the local server (vs. client) for the number of captures.
FIXME on refactoring the signature path, which is duplicated at several places.
FIXME on fixing an issue with filter name, which doesn't get included in the capture path when there is no filter wheel, but still gets included in the signature (workaround: use a filter wheel sim).
FIXME on finishedFramesCount variable, which is part of an unfinished mechanism and should be removed.
FIXME on files counted in signature path, because all files are counted, not just captures.
FIXME on duplicate scheduler jobs vs. duplicate sequence jobs.
FIXME on altitude cutoff, which might cause jobs to loop over themselves until altitude is properly either allowing startup, or causing effective abort (3 degrees sidereal delay).