Differential D12357

OSX build fails without include of QApplication
ClosedPublic
Actions

Authored by deisenlord on Apr 19 2018, 4:52 PM.

Details

Reviewers
lancaster
mutlaqja
Commits
R321:f63ef758f48c: OSX build fails without include of QApplication
Summary

OSX build fails with the following if QApplication is not included.

error: incomplete type 'QApplication' named in nested name
specifier
connect(QApplication::instance(), SIGNAL(applicationStateChanged(Qt::ApplicationState)), this,
^~~~~~~~~~~~~~
/usr/local/opt/qt/lib/QtGui.framework/Headers/qwindowdefs.h:81:7: note: forward declaration of 'QApplication'

Diff Detail

Repository
R321 KStars
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
deisenlord created this revision.Apr 19 2018, 4:52 PM
Restricted Application added a project: KDE Edu. · View Herald TranscriptApr 19 2018, 4:52 PM
Restricted Application added a subscriber: KDE Edu. · View Herald Transcript
deisenlord requested review of this revision.Apr 19 2018, 4:52 PM
deisenlord added reviewers: lancaster, mutlaqja.
mutlaqja accepted this revision.Apr 19 2018, 5:06 PM
This revision is now accepted and ready to land.Apr 19 2018, 5:06 PM
Closed by commit R321:f63ef758f48c: OSX build fails without include of QApplication (authored by mutlaqja). · Explain WhyApr 19 2018, 5:09 PM
This revision was automatically updated to reflect the committed changes.
mutlaqja added a comment.Apr 19 2018, 5:10 PM

Can you please use Arcanist in the future so that the author metadata are reserved?

deisenlord added a comment.Apr 19 2018, 5:12 PM

Sure thing, not familar but will get so.

Revision Contents
Changeset List

PathPackages
Mkstars/indi/guimanager.cpp (1 line)

Diff 32577

View Options

kstars/indi/guimanager.cpp

Loading...