Differential D12356

Move volume constants into functions
ClosedPublic
Actions

Authored by nicolasfella on Apr 19 2018, 3:21 PM.

Details

Reviewers
drosca
apol
Commits
R994:c102a76c9538: Move volume constants into functions
Summary

Get rid of pulse include in context.h

Test Plan

KDE Connect volume control still works with correct bounds

Diff Detail

Repository
R994 Pulseaudio Qt Bindings
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
nicolasfella created this revision.Apr 19 2018, 3:21 PM
Restricted Application added a project: Plasma. · View Herald TranscriptApr 19 2018, 3:21 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
nicolasfella requested review of this revision.Apr 19 2018, 3:21 PM
drosca requested changes to this revision.Apr 19 2018, 4:34 PM

Yes, that's what I had in mind. But please make it build (MinimalVolume in header vs minimalVolume in source).

Also I think we should use "minimum" instead of "minimal", same with "maximal" -> "maximum".

This revision now requires changes to proceed.Apr 19 2018, 4:34 PM
nicolasfella updated this revision to Diff 32583.Apr 19 2018, 5:28 PM
  • Fix names
nicolasfella added a comment.Apr 19 2018, 5:29 PM

Weird, it did build for me so I didn't notice, sorry

drosca accepted this revision.Apr 19 2018, 5:32 PM

Yeah, sorry, it would actually build, but it wouldn't do what you wanted.

This revision is now accepted and ready to land.Apr 19 2018, 5:32 PM
Closed by commit R994:c102a76c9538: Move volume constants into functions (authored by nicolasfella). · Explain WhyApr 19 2018, 5:35 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/context.h (9 lines)
Msrc/context.cpp (14 lines)
Msrc/context_p.h (5 lines)

Diff 32584

View Options

src/context.h

Loading...
View Options

src/context.cpp

Loading...
View Options

src/context_p.h

Loading...