combine code of alltracks and album view into a somewhat generic implementation of a list browser
Details
Details
- Reviewers
mgallien - Group Reviewers
Elisa - Commits
- R255:7be7098cc6de: implement a generic listview
all tracks view and album view work as before
Diff Detail
Diff Detail
- Repository
- R255 Elisa
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Thanks for removing code.
Please fix the issues.
| src/qml/ListBrowserView.qml | ||
|---|---|---|
| 33–34 | Could you use an alias property ? | |
| 115–119 | This is probably not good for performance. Why do you still define the delegate inside the ListBrowserView component instead of setting the delegate at the places where you instantiate the ListBrowserView component. | |
| src/qml/ListBrowserView.qml | ||
|---|---|---|
| 115–119 | That's what I first tried, but the delegates need to know about some properties, for example the width of the listview, which are not available when defined outside. Do you have any ideas how to solve this? | |
| src/qml/ListBrowserView.qml | ||
|---|---|---|
| 115–119 | You can create alias properties in ListBrowserView to expose the properties of the ListView child. This way, you should be able to move out the delegate (and reduce the size of this file). This way, ListBrowserView can have somehow the same interface than ListView. | |