This massively reduces the installation size of an application on Windows.
The rcc is 50mb while the uncompressed files are 150mb.
mlaurent |
This massively reduces the installation size of an application on Windows.
The rcc is 50mb while the uncompressed files are 150mb.
No Linters Available |
No Unit Test Coverage |
Remove indent and commit it :)
Thanks
src/plugins/hunspell/hunspellclient.cpp | ||
---|---|---|
104 | fix indent |
Turns out that my test was a bit too small.
While sonnet finds the dicts and marked my random typed stuff as wrong it also marks everything as wrong.
Sonnet might have no problems with the rcc but hunspell has.
Hunspell(const char* affpath, const char* dpath, const char* key = NULL);
The constructor only takes a file path and creates an invalid speller if the file does not exist.
So I guess I'm going to abandon the review....
src/plugins/hunspell/hunspelldict.cpp | ||
---|---|---|
104 | not necessary to check pointer here. |
While the disk use of the installation goes down the ram usage explodes as QResource doesn't use mmap https://github.com/qt/qtbase/blob/a37dd93defd91b79fb6730d0ff0515a66a0d3972/src/corelib/io/qresource.cpp#L1037
Would adding a mmap implementation on Windows like https://github.com/witwall/mman-win32 be an option ?
IINM, in the commit message s/form a rcc/from an rcc/.
Edit: (I hope this ^ didn't sound snobby, it's really not at all).