Differential D12270

Create a public function to access the actionMenu
AbandonedPublic
Actions

Authored by ngraham on Apr 17 2018, 3:08 AM.

Details

Reviewers
None
Group Reviewers
Frameworks
Summary

Create a public function to access the actionMenu, so clients and subclasses can manipulate it as they see fit.

BUG: 83679
FIXED-IN: 5.46

Diff Detail

Repository
R241 KIO
Branch
public-actionmenu (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
ngraham created this revision.Apr 17 2018, 3:08 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptApr 17 2018, 3:08 AM
ngraham requested review of this revision.Apr 17 2018, 3:08 AM
broulik added a subscriber: broulik.Apr 17 2018, 12:21 PM

This bug is 15 years old and no proof to this claim was provided.
Also, the wording as "subclasses can add" suggests a virtual method

ngraham added a comment.Apr 17 2018, 1:11 PM

If you'd like, I can abandon the diff and WONTFIX the bug. I'm just trying to fix low-hanging fruit issues as I triage old KIO bugs.

ngraham abandoned this revision.May 10 2018, 6:56 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald TranscriptMay 10 2018, 6:56 PM

Revision Contents
Changeset List

Diff 32358

View Options

src/filewidgets/kdiroperator.h

Loading...
View Options

src/filewidgets/kdiroperator.cpp

Loading...