Differential D12224

Use Tree View as the default view mode in the Filesystem Browser plugin
ClosedPublic
Actions

Authored by ngraham on Apr 15 2018, 12:47 PM.

Details

Reviewers

dhaumann

Group Reviewers

Kate

Commits

R40:c87e4cb1e48f: Use Tree View as the default view mode in the Filesystem Browser plugin

Summary

Previously, Kate's Filesystem Browser plugin was replying on a bug in KDirOperator that was just fixed: the fact that columns perviously did not auto-size correctly and did not stick to the right edge when the view was resized. This was fixed in D11993.

Now that this bug is fixed, the plugin needs to default to a more sensible view mode--one that does not have additional columns. This patch does that.

Test Plan

Create and log into a new user account → open Kate → Settings → Configure Kate → Plugins → turn on "Filesystem Browser" plugin → hit Apply → click "Filesystem Browser" on the sidebar

Before:

After:

Diff Detail

Repository

R40 Kate

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

ngraham created this revision.Apr 15 2018, 12:47 PM

Restricted Application added a project: Kate. · View Herald TranscriptApr 15 2018, 12:47 PM

ngraham requested review of this revision.Apr 15 2018, 12:47 PM

ngraham edited the test plan for this revision. (Show Details)Apr 15 2018, 12:51 PM

ngraham edited the summary of this revision. (Show Details)

I think this is nice, but is this patch a problem if you have new Kate with KTextEditor < 5.46?

No, There should be no issue with switching to tree view by default for Kate when using older Frameworks. In some sense it's an upgrade for those users too since the filesystem browser then won't have a horizontal scrollbar and will focus on its primary purpose: files.

Also, the other two panels available in the sidebar currently display their content in Tree View, so this would make Filesystem Browser consistent with them.

Ok, then thanks & please go ahead in master branch.

This revision is now accepted and ready to land.Apr 15 2018, 4:26 PM

Thanks, will do!

Closed by commit R40:c87e4cb1e48f: Use Tree View as the default view mode in the Filesystem Browser plugin (authored by ngraham). · Explain WhyApr 15 2018, 4:28 PM

This revision was automatically updated to reflect the committed changes.

ngraham mentioned this in D12358: Use Tree view for the file browser instead of whatever the default view happens to be set to.Apr 19 2018, 5:25 PM

ngraham mentioned this in D12360: Use Tree view for the file browser instead of whatever the default view happens to be set to.Apr 19 2018, 5:38 PM

ngraham mentioned this in R468:ccd2acd8bd60: Use Tree view for the file browser instead of whatever the default view happens….Apr 19 2018, 6:24 PM

tfry mentioned this in R5:7c13e680bfe2: Use Tree view for the file browser instead of whatever the default view happens….Apr 19 2018, 6:33 PM

tfry mentioned this in R5:0883e2bb9df2: Use Tree view for the file browser instead of whatever the default view happens….

Revision Contents
Changeset List

			Path	Packages
M			addons/filebrowser/katefilebrowser.cpp (3 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	32185	8014198		Apr 15 2018, 12:47 PM	★	★
Diff 2	32194	8014198	R40:c87e4cb1e48f26a31eb3492a2db28e71bfd707ab	Apr 15 2018, 4:25 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
97aa154f5d26	a95cebd988ba	8014198d4f99	Nathaniel Graham	Use Tree View as the default view mode in the Filesystem Browser plugin (Show More…)	Apr 15 2018, 12:43 PM

Diff 32194

View Options

addons/filebrowser/katefilebrowser.cpp