An empty "available devices" section does make it clear that none of the devices are available at the moment (which might be unclear with only "remembered devices"). I'd suggest only hiding it there's at least one connected device.

Only hide section when there is at least one device connected

Looks good to me!

This revision is now accepted and ready to land.Apr 17 2018, 6:42 PM

Closed by commit R225:9837c89f350e: Hide Available devices section if no devices are available (authored by nicolasfella). · Explain WhyApr 17 2018, 6:48 PM

This revision was automatically updated to reflect the committed changes.

nicolasfella mentioned this in D12334: Fix SharePlugin devices list.Apr 19 2018, 12:47 AM

nicolasfella mentioned this in R225:9bf5a9c4899c: Fix SharePlugin devices list.May 11 2018, 7:20 PM

Revision Contents
Changeset List

			Path	Packages
M			src/org/kde/kdeconnect/UserInterface/List/SectionItem.java (6 lines)
M			src/org/kde/kdeconnect/UserInterface/PairingFragment.java (30 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	32150	2cd7d4b		Apr 14 2018, 8:39 PM	★	★
Diff 2	32411	2cd7d4b	- Only hide section when there is at least one device connected	Apr 17 2018, 5:23 PM	★	★
Diff 3	32419	4d2357f	R225:9837c89f350e8deb0449db7423909b18d0c6a189	Apr 17 2018, 6:48 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
3ceb9a7710f3	449418d154c0	effb37c6162d	Nicolas Fella	Only hide section when there is at least one device connected	Apr 17 2018, 5:23 PM
effb37c6162d	bae13aa4e1d1	2cd7d4b7a99a	Nicolas Fella	Hide Available devices section if no devices are available (Show More…)	Apr 14 2018, 8:37 PM

Hide Available devices section if no devices are availableClosedPublicActions

Details

Diff Detail

Revision ContentsChangeset List

Diff 32411

src/org/kde/kdeconnect/UserInterface/List/SectionItem.java

src/org/kde/kdeconnect/UserInterface/PairingFragment.java

Hide Available devices section if no devices are available
ClosedPublic
Actions

Revision Contents
Changeset List