[Slideshow Wallpaper] Fix seconds always set to 1 when opening config dialog
ClosedPublic
Actions

Authored by broulik on Mar 25 2016, 4:07 PM.

Details

Reviewers

Group Reviewers

Commits

R120:7656fa02e680: [Slideshow Wallpaper] Fix seconds always set to 1 when opening config dialog
R871:7656fa02e680: [Slideshow Wallpaper] Fix seconds always set to 1 when opening config dialog

Summary

BUG: 350828
FIXED-IN: 5.7.0

Test Plan

Depends on D1220

For the first time I'm actually amazged by Phabricator, it automatically recognized my "Depends on $other revision" and populated the field automatically.

Diff Detail

Repository

R120 Plasma Workspace

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

broulik updated this revision to Diff 2954.Mar 25 2016, 4:07 PM

broulik retitled this revision from to [Slideshow Wallpaper].

broulik updated this object.

broulik edited the test plan for this revision. (Show Details)

broulik added a reviewer: Plasma.

broulik set the repository for this revision to R120 Plasma Workspace.

broulik added a project: Plasma.

broulik added a dependency: D1220: [Applet / Wallpaper Configuration] Load config page with initial cfg properties already set.

Restricted Application added a subscriber: plasma-devel. · View Herald TranscriptMar 25 2016, 4:07 PM

broulik edited the test plan for this revision. (Show Details)Mar 25 2016, 4:08 PM

broulik retitled this revision from [Slideshow Wallpaper] to [Slideshow Wallpaper] Fix seconds always set to 1 when opening config dialog.Mar 25 2016, 4:25 PM

broulik updated this object.

mart accepted this revision.Apr 4 2016, 9:35 AM

mart added a reviewer: mart.

This revision is now accepted and ready to land.Apr 4 2016, 9:35 AM

Closed by commit R120:7656fa02e680: [Slideshow Wallpaper] Fix seconds always set to 1 when opening config dialog (authored by broulik). · Explain WhyApr 6 2016, 7:18 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			wallpapers/image/imagepackage/contents/ui/config.qml (25 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	2954			Mar 25 2016, 4:06 PM	★	★
Diff 2	3154	799ad2d	rPLASMAWORKSPACE7656fa02e680bbc85dd03635149cc6643f5aa51a	Apr 6 2016, 7:17 AM	★	★

	Status	Author	Revision
	Closed	broulik	D1221 [Slideshow Wallpaper] Fix seconds always set to 1 when opening config dialog
	Closed	broulik	D1220 [Applet / Wallpaper Configuration] Load config page with initial cfg properties already set

Diff 3154

View Options

wallpapers/image/imagepackage/contents/ui/config.qml