Differential D12205

Update AtCore::PrintWidget
ClosedPublic
Actions

Authored by rizzitello on Apr 14 2018, 7:42 PM.

Details

Reviewers
tcanabrava
patrickelectric
laysrodrigues
Commits
R232:b52aaab40ac3: update for widget changes
R232:10eab59960a6: Update AtCore::PrintWidget
R232:f8c2e58aa5bb: Remove the fan controls
R232:b5738c2c0c5d: Add Fan Controls, Creation toggle for all controls, Documentation
Summary
  • Add Fan Controls
  • Creation toggle for all controls
  • Documentation

TemperatureWidget:

  • Remove Fan Controls

Diff Detail

Repository
R232 AtCore
Branch
tempPrintUpdate
Lint
No Linters Available
Unit
No Unit Test Coverage
rizzitello requested review of this revision.Apr 14 2018, 7:42 PM
rizzitello created this revision.
rizzitello edited the summary of this revision. (Show Details)Apr 14 2018, 7:43 PM
rizzitello added reviewers: tcanabrava, patrickelectric, laysrodrigues.
rizzitello added a project: Atelier: AtCore.
rizzitello added a subscriber: Atelier: AtCore.
patrickelectric requested changes to this revision.Apr 15 2018, 6:20 PM
patrickelectric added inline comments.
src/widgets/printwidget.cpp
102

80 ? This should be the alignment right ?

src/widgets/printwidget.h
99

Alphabetic order

This revision now requires changes to proceed.Apr 15 2018, 6:20 PM
rizzitello updated this revision to Diff 32206.Apr 15 2018, 6:34 PM
rizzitello marked 2 inline comments as done.
rizzitello edited the summary of this revision. (Show Details)
  • update for widget changes
rizzitello added inline comments.Apr 15 2018, 6:35 PM
src/widgets/printwidget.cpp
102

Naw we want it to use 80% of the layout space

patrickelectric accepted this revision.Apr 15 2018, 7:31 PM
This revision is now accepted and ready to land.Apr 15 2018, 7:31 PM
rizzitello closed this revision.Apr 15 2018, 7:55 PM

Revision Contents
Changeset List

Diff 32206

View Options

src/widgets/printwidget.h

Loading...
View Options

src/widgets/printwidget.cpp

Loading...
View Options

src/widgets/temperaturewidget.h

Loading...
View Options

src/widgets/temperaturewidget.cpp

Loading...
View Options

testclient/mainwindow.cpp

Loading...