Differential D12204

Replace PushgCodeWidget with AtCore::commandWidget
ClosedPublic
Actions

Authored by rizzitello on Apr 14 2018, 7:06 PM.

Details

Reviewers
patrickelectric
tcanabrava
laysrodrigues
Commits
R231:ca9e04a44df8: Replace PushgCodeWidget with AtCore::commandWidget
R231:27b05a46acd3: Replace PushgCodeWidget with AtCore::commandWidget
Summary
  • Replace PushGcodeWidget with AtCore::CommandWidget.

This provides the push command and show message controls.

Diff Detail

Repository
R231 Atelier
Branch
commandWidget
Lint
No Linters Available
Unit
No Unit Test Coverage
rizzitello requested review of this revision.Apr 14 2018, 7:06 PM
rizzitello created this revision.
patrickelectric requested changes to this revision.Apr 15 2018, 6:15 PM
patrickelectric added inline comments.
src/widgets/atcoreinstancewidget.cpp
257

const ref command

262

const ref

src/widgets/atcoreinstancewidget.h
85

alphabetic order

This revision now requires changes to proceed.Apr 15 2018, 6:15 PM
rizzitello updated this revision to Diff 32226.Apr 15 2018, 8:39 PM
  • Use const ref
rizzitello marked 2 inline comments as done.Apr 15 2018, 8:39 PM
patrickelectric accepted this revision.Apr 15 2018, 8:46 PM
This revision is now accepted and ready to land.Apr 15 2018, 8:46 PM
rizzitello closed this revision.Apr 15 2018, 8:49 PM

Revision Contents
Changeset List

Diff 32226

View Options

src/widgets/CMakeLists.txt

Loading...
View Options

src/widgets/atcoreinstancewidget.h

Loading...
View Options

src/widgets/atcoreinstancewidget.cpp

Loading...
View Options

src/widgets/atcoreinstancewidget.ui

Loading...
View Options

src/widgets/pushgcodewidget.h

Loading...
View Options

src/widgets/pushgcodewidget.cpp

Loading...