The output looks great - was mimicking xterms '\e[ q' too hard or not worth the effort? Also, it would be good if you could fill out the "testing" part; for example, you could copy/paste the printf commands from the bug report.

In D12193#248547, @hindenburg wrote:

The output looks great - was mimicking xterms '\e[ q' too hard or not worth the effort?

I am not sure what you mean, but if you mean the code in the Vt102Emulation, it took me a long time to understand the 'lec' and co. parts, and a lot of trial and error; the comment at the top of that section says "Ok, here comes the nasty part of the decoder.", which is true, it's quite nasty.

Also, it would be good if you could fill out the "testing" part; for example, you could copy/paste the printf commands from the bug report.

OK, I fleshed out the test plan section a bit.

In xterm, the number 0 or omitting the number is the same as number 1.

In vte we intentionally differ, the number 0 or omitting the number means to revert to the default (the shape is taken from profile prefs, blinking is from GNOME-wide setting).

I tested omitting the # in xterm and it works as if there was 1 - I think we'd rather follow xterm than vte ATM

In D12193#248718, @hindenburg wrote:

In xterm, the number 0 or omitting the number is the same as number 1.

In vte we intentionally differ, the number 0 or omitting the number means to revert to the default (the shape is taken from profile prefs, blinking is from GNOME-wide setting).

---

I tested omitting the # in xterm and it works as if there was 1 - I think we'd rather follow xterm than vte ATM

Ah, sorry, I didn't get what you meant before.

I'll see what I can do, might as well be fully compatible with xterm regarding the cursor style.

I notice that using 'reset' in FreeBSD does not change the cursor back to profile setting.

In D12193#249794, @hindenburg wrote:

I notice that using 'reset' in FreeBSD does not change the cursor back to profile setting.

reset on my box is provided by ncurses-6.0; does BSD has something different?

From what I can tell, they are different programs. It is not a show stopper, just a note.