Make clients select password
Needs ReviewPublic
Actions

Authored by rishabhg on Apr 14 2018, 11:32 AM.

Details

Reviewers

jjazeix
timotheegiet

Summary

To be merged in Branch Network Client

Repository

R2 GCompris

Lint

Lint Skipped

Unit

Unit Tests Skipped

Restricted Application added a subscriber: KDE Edu. · View Herald Transcript

rishabhg requested review of this revision.Apr 14 2018, 11:32 AM

src/core/main.qml
361	If there are images, I would display all the potential images for passwords, not just the one from the group. If there are only 2 children in the group, you will only have the 2 images displayed and each child will know the other child password.
437	Either the child is old enough to type his password, we don't provide a list of all passwords and he has to type. Or for younger children, we can display it as a Grid of images with a OK/Cancel button and the child has to select the good image and click on OK.
461	can there be a better name than _2?

			Path	Packages
M			src/core/ClientNetworkMessages.h (2 lines)
M			src/core/ClientNetworkMessages.cpp (4 lines)
M			src/core/DataStreamConverter.h (2 lines)
M			src/core/Messages.h (1 line)
M			src/core/main.qml (58 lines)