| rkflx |
| Gwenview |
If an SVG image is reloaded (F5 or File → Reload) the
QSvgRenderer is not updated after loading and Gwenview crashes
when trying to zoom. If the SVG file is changed outside Gwenview
while it is viewed and then reloaded it's not updated.
This is caused by a missing connection to the loaded() signal
and calling SvgImageView::finishLoadFromDocument() to setup the
new renderer.
BUG: 359736
FIXED-IN: 18.04.1
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
| lib/documentview/svgviewadapter.cpp | ||
|---|---|---|
| 55–56 | The loaded() signal has already been emitted so we need to call finishLoadFromDocument() here. The check is not needed at the moment since SvgDocumentLoadedImpl::loadingState() always returns Document::Loaded but this may change in future. | |
Tested and working in both cases, and code makes sense.
This says FIXED-IN: 18.04.1, but is branched from master... in case you weren't aware.
Haha, reading the title I thought this was a fix for https://bugs.kde.org/show_bug.cgi?id=131068, but eliminating a crash is even better, of course ;)
Apart from the comment LGTM (but make sure to land to stable).
| lib/documentview/svgviewadapter.cpp | ||
|---|---|---|
| 58 | First I had trouble understanding the comment. After reading f827f8a95, how about: // Ensure finishLoadFromDocument is also called when // - loadFromDocument was called before the document was fully loaded // - reloading is triggered (e.g. via F5) As you mentioned, currently the first case can never happen, but at least this would correspond to the if. | |
Oh, thanks - I really didn't notice that.
| lib/documentview/svgviewadapter.cpp | ||
|---|---|---|
| 58 | That's a much better description. :) | |