Differential D12182

Fix leak when adding job with invalid RA/DEC
ClosedPublic
Actions

Authored by TallFurryMan on Apr 13 2018, 9:47 PM.

Details

Reviewers
mutlaqja
Summary

When a Scheduler Job is saved and it is new, a new instance of SchedulerJob is created.
If somehow assigned RA/DEC, saving the job is aborted, but the new instance is not deleted.

Test Plan

Adding a new Scheduler job, or editing an existing Scheduler job, still functions properly. Leak is probably negligible in the standard user activity.

Diff Detail

Repository
R321 KStars
Lint
Lint Skipped
Unit
Unit Tests Skipped
TallFurryMan created this revision.Apr 13 2018, 9:47 PM
Restricted Application added a project: KDE Edu. · View Herald TranscriptApr 13 2018, 9:47 PM
Restricted Application added a subscriber: KDE Edu. · View Herald Transcript
TallFurryMan requested review of this revision.Apr 13 2018, 9:47 PM
mutlaqja accepted this revision.Apr 14 2018, 7:32 AM
This revision is now accepted and ready to land.Apr 14 2018, 7:32 AM
TallFurryMan closed this revision.May 18 2018, 8:26 AM

Housework.

Restricted Application edited subscribers, added: kde-edu; removed: KDE Edu. · View Herald TranscriptMay 18 2018, 8:26 AM

Revision Contents
Changeset List

Diff 32082

View Options

kstars/ekos/scheduler/scheduler.cpp

Loading...