Chart: Remove unused frame/background stuff from legend
ClosedPublic
Actions

Authored by danders on Apr 13 2018, 9:51 AM.

Details

Reviewers

Group Reviewers

Calligra: 3.0

Commits

Summary

Remove setter/getters and ui.

These things are controlled from the Shape Tool,
so the KChart things shall not be used.

Repository

R8 Calligra

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

danders requested review of this revision.Apr 13 2018, 9:51 AM

That's a good catch. The charts always did feel a little sort of... external, which i guess this goes some way to explain :)

This revision is now accepted and ready to land.Apr 13 2018, 12:29 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			plugins/chartshape/ChartConfigWidget.cpp (6 lines)
M			plugins/chartshape/ChartConfigWidget.ui (55 lines)
M			plugins/chartshape/ChartTool.h (4 lines)
M			plugins/chartshape/ChartTool.cpp (53 lines)
M			plugins/chartshape/Legend.h (10 lines)
M			plugins/chartshape/Legend.cpp (99 lines)
M			plugins/chartshape/commands/LegendCommand.h (3 lines)
M			plugins/chartshape/commands/LegendCommand.cpp (35 lines)