Add profile property to toggle alternate scrolling
ClosedPublic

Authored by ahmadsamir on Apr 12 2018, 7:40 AM.

Details

Summary

Konsole sends up/down key press events to programs running in the shell
if they indicate they are not interested in mouse events. This adds a
profile property to toggle this behaviour.

BUG: 170582
FIXED-IN: 18.08

Diff Detail

Repository
R319 Konsole
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ahmadsamir created this revision.Apr 12 2018, 7:40 AM
Restricted Application added a project: Konsole. · View Herald TranscriptApr 12 2018, 7:40 AM
ahmadsamir requested review of this revision.Apr 12 2018, 7:40 AM

OK, this is fine - I wonder who would disable this per-profile; especially with the upcoming other patch.

OK, this is fine - I wonder who would disable this per-profile; especially with the upcoming other patch.

That's a good point; but looking at the bug report, old as it is, there were/are more than a few users who wanted that behaviour disabled everywhere.

So with a profile option, users can enable it everywhere and disable it selectively with the escape sequence; or the other way around, disable it everywhere and selectively enable it for programs like less which don't support mouse scrolling on their own (and which was the original point of adding the emulation of up/down key presses).

Just thinking out loud here.

hindenburg accepted this revision.Apr 13 2018, 12:45 AM

That's fine - basically my thought as well - just a lot of options

This revision is now accepted and ready to land.Apr 13 2018, 12:45 AM
This revision was automatically updated to reflect the committed changes.