Make it possible to use QQC.Action with the GlobalDrawer.
Don't assume applicationWindow() is defined.
This way I can adopt it in Discover right away.
Details
Details
- Reviewers
mart - Group Reviewers
Plasma - Commits
- R169:28512edcda90: Soft decouple of data structures
Discover works on the compact mode, just like it used to with
the mobile components.
Diff Detail
Diff Detail
- Repository
- R169 Kirigami
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
For reference, that's what I'm talking about: http://commits.kde.org/discover/b6ac9bf60e4961c77b321535d3200d25fd563f58
Comment Actions
fine altough applicationWindow() is assumed in many places is existing, it's kindof an issue still not using it..
(btw, any reason you can't use an instance of ApplicationWindow ?)
i was thinking about if some of the properties that are usually accessed from there could make sense inside a singleton itself, it could make it less necessary...
Comment Actions
I don't want to destroy the window and create a different one when changing from mobile to desktop.
i was thinking about if some of the properties that are usually accessed from there could make sense inside a singleton itself, it could make it less necessary...
Maybe that could help. In fact I have such a singleton in Discover as well for similar reasons.