Differential D12066

[options] Disable prior selections of EGL on X backend
AbandonedPublic
Actions

Authored by romangg on Apr 9 2018, 1:03 PM.

Details

Reviewers
None
Group Reviewers
KWin
Summary

In the past the OpenGl backend could be changed via a KCM on X between GLX
and EGL. This was removed since the EGL path is basically not supported
anymore. Some user configs might still have a key for EGL selection though
from before that and therefore force EGL on X without knowing and with no
way now to change this in gui.

This change renames the egl config key and by that disables prior selections
of the unsupported backend. The backend can still be forced knowingly by
setting the new config key.

CCBUG: 392752

Test Plan

Not tested.

Diff Detail

Repository
R108 KWin
Branch
eglXConfigName
Lint
No Linters Available
Unit
No Unit Test Coverage
romangg created this revision.Apr 9 2018, 1:03 PM
Restricted Application added a project: KWin. · View Herald TranscriptApr 9 2018, 1:03 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
romangg requested review of this revision.Apr 9 2018, 1:03 PM
davidedmundson added a subscriber: davidedmundson.Apr 19 2018, 10:06 PM

That "fixes" it for those who accidentally have it enabled but don't want it
but breaks it for those who deliberately went and enabled it (possibly with the GUI, possibly manually)

One doesn't seem particularly better than the other.

graesslin added a subscriber: graesslin.Apr 22 2018, 7:30 PM

There are users who only could get Egl to work. The setting was only removed as users "read on informed Internets" that it was better. For very few that's the case, for most it isn't. Nevertheless I don't think it would be good to break this for users who deliberately want to use it. From bug reports this is rather seldom a problem nowadays.

romangg abandoned this revision.May 1 2018, 9:10 PM

Revision Contents
Changeset List

PathPackages
Moptions.cpp (4 lines)

Diff 31735

View Options

options.cpp

Loading...