These new functions to access the next and previous tabs are not used by anything yet, but it is envisioned that they would be useful for a variety of purposes--such as the "open path in new tab" feature from D11703
Details
Details
- Reviewers
elvisangelaccio - Group Reviewers
Dolphin - Commits
- R318:b12a7b0f24d5: Add more tab access functions
Dolphin still compiled and runs; new code is not actually used anywhere
Diff Detail
Diff Detail
- Repository
- R318 Dolphin
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
| src/dolphintabwidget.h | ||
|---|---|---|
| 55–56 | We should also mention that the function will return nullptr if there is only one tab. | |
| 61–62 | Same here. | |
| 64 | We already have a m_previousTab variable that has a different meaning (previous = the tab that was previously active). We should either rename this variable (e.g. m_previousActiveTab?), or find another name for this new function (but I cannot think of one...) | |