Store vendor ID in tablet information when detecting connected tablets.
This is later used for libWacom lookup.
Look up tablet information via libWacom if tablet is not found in local
and system device databases.
Details
Details
- Reviewers
fvogt xuetianweng - Commits
- R530:336c1e206a55: Initial libWacom support
temporary removed tablet definiton from the bundled DB and checked that it still works with libwacom picked defintion
Diff Detail
Diff Detail
- Repository
- R530 Wacom tablet support
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Looks ok to me, I just added a few suggestions.
| src/common/libwacomwrapper.cpp | ||
|---|---|---|
| 50 | I suggest to use a std::unique_ptr with custom deleter here instead of calling the free functions manually. | |
| src/common/libwacomwrapper.h | ||
| 37 | Also move to the private: section? | |
| src/kded/tabletfinder.cpp | ||
| 187–188 | I'd keep the "Could not find tablet with id '%1' in database." message, currently it doesn't show the ID if it's not found. | |
Comment Actions
- Fix setting NumPadButtons in TabletInformation from libwacom (int gets converted to bool because there's no int version of set())