Differential D11899

Set focus back to image view after leaving edit tool
ClosedPublic
Actions

Authored by muhlenpfordt on Apr 3 2018, 6:24 AM.

Details

Reviewers
rkflx
Group Reviewers
Gwenview
Commits
R260:7369f4719529: Set focus back to image view after leaving edit tool
R260:75b1ab4d2355: Merge remote-tracking branch 'origin/Applications/18.04'
Summary

If you click on the toolbar of an image edit tool (crop, redeye)
the focus is lost after leaving the tool and you cannot switch images
with cursor keys.
This patch resets the focus to image view after leaving the edit tool.

BUG: 321091

Test Plan
  • Open image in Gwenview View Mode (normal or fullscreen)
  • Start crop tool (⇧+C)
  • Click on Crop or Cancel
  • Switching images with cursor keys should work as usual

Diff Detail

Repository
R260 Gwenview
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
muhlenpfordt requested review of this revision.Apr 3 2018, 6:24 AM
muhlenpfordt created this revision.
huoni added a subscriber: huoni.Apr 3 2018, 7:01 AM

Tested and working, and code looks good to me.

rkflx accepted this revision.Apr 3 2018, 11:56 PM
rkflx added a subscriber: rkflx.
In D11899#238954, @huoni wrote:

Tested and working, and code looks good to me.

…then I'll better accept the Diff quickly, before it ends up in the review queue :D

Anyway, thanks for the patch @muhlenpfordt. I cannot find anything wrong with it. In wonder why you branched from master, though, because to me the bugfix sounds like material for the stable branch.

This revision is now accepted and ready to land.Apr 3 2018, 11:56 PM
muhlenpfordt added a comment.Apr 4 2018, 6:30 AM
In D11899#239440, @rkflx wrote:

wonder why you branched from master, though, because to me the bugfix sounds like material for the stable branch.

Ok, I always forget about this. ;) I'll commit to Applications/18.04 first.
Thanks to both of you for testing. 🙂

Closed by commit R260:7369f4719529: Set focus back to image view after leaving edit tool (authored by muhlenpfordt). · Explain WhyApr 4 2018, 6:44 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mapp/viewmainpage.h (3 lines)
Mapp/viewmainpage.cpp (10 lines)

Diff 31260

View Options

app/viewmainpage.h

Loading...
View Options

app/viewmainpage.cpp

Loading...