Differential D1188

[client] Add setScale to Surface
ClosedPublic
Actions

Authored by graesslin on Mar 21 2016, 8:34 AM.

Details

Reviewers
sebas
Group Reviewers
Plasma
Commits
R127:c734cd5c555f: [client] Add setScale to Surface
Summary

The wrapper for wl_surface::set_buffer_scale was still missing.
Main reason for implementation is the need for the added auto-test.

Diff Detail

Repository
R127 KWayland
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
graesslin updated this revision to Diff 2871.Mar 21 2016, 8:34 AM
graesslin retitled this revision from to [client] Add setScale to Surface.
graesslin updated this object.
graesslin edited the test plan for this revision. (Show Details)
graesslin added a reviewer: Plasma.
Restricted Application added a project: Plasma. · View Herald TranscriptMar 21 2016, 8:34 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
sebas accepted this revision.Mar 21 2016, 2:09 PM
sebas added a reviewer: sebas.
sebas added a subscriber: sebas.

Fix the minor comments and go for it.

src/client/surface.h
208 ↗(On Diff #2871)

It's

212 ↗(On Diff #2871)

-the, -then (makes it clearer and easier to read)

This revision is now accepted and ready to land.Mar 21 2016, 2:09 PM
graesslin marked 2 inline comments as done.Mar 21 2016, 2:59 PM
Closed by commit R127:c734cd5c555f: [client] Add setScale to Surface (authored by graesslin). · Explain WhyMar 21 2016, 3:19 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 2882

View Options

autotests/client/test_wayland_surface.cpp

Loading...
View Options

src/client/surface.h

Loading...
View Options

src/client/surface.cpp

Loading...