Proofread online help docbook
ClosedPublic

Authored by lueck on Apr 1 2018, 7:21 PM.

Details

Summary

check link vailidity + change http -> https
bump date + releaseinfo

Test Plan

checkXML5 doc/onlinehelp/index.docbook

Diff Detail

Repository
R125 KHelpCenter
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
lueck created this revision.Apr 1 2018, 7:21 PM
Restricted Application added a project: Documentation. · View Herald TranscriptApr 1 2018, 7:21 PM
Restricted Application added a subscriber: kde-doc-english. · View Herald Transcript
lueck requested review of this revision.Apr 1 2018, 7:21 PM
yurchor accepted this revision as: yurchor.Apr 1 2018, 7:29 PM
yurchor added a subscriber: yurchor.
yurchor added inline comments.
doc/onlinehelp/index.docbook
25

Would it be better to use "/Special:myLanguage" to open the page in the user's locale language?

Example: https://userbase.kde.org/Special:myLanguage/What_is_KDE

27

same here

34

same here

43

same here

52

Same here

78

same here

This revision is now accepted and ready to land.Apr 1 2018, 7:29 PM
lueck added a comment.Apr 1 2018, 7:48 PM

yurchor wrote

Would it be better to use "/Special:myLanguage" to open the page in the user's locale language?
Example: https://userbase.kde.org/Special:myLanguage/What_is_KDE

good catch, but if you are not logged in, Special:myLanguage just redirects to locale en

Should I use https://userbase.kde.org/What_is_KDE/en ?
Then translators can check if a translated page exists and decide to use en or their locale?

yurchor wrote

Would it be better to use "/Special:myLanguage" to open the page in the user's locale language?
Example: https://userbase.kde.org/Special:myLanguage/What_is_KDE

good catch, but if you are not logged in, Special:myLanguage just redirects to locale en

Should I use https://userbase.kde.org/What_is_KDE/en ?
Then translators can check if a translated page exists and decide to use en or their locale?

Looks good to me.

yurchor wrote

Would it be better to use "/Special:myLanguage" to open the page in the user's locale language?
Example: https://userbase.kde.org/Special:myLanguage/What_is_KDE

good catch, but if you are not logged in, Special:myLanguage just redirects to locale en

Uh, I tried on my browser and it opened the Italian version of that page, and I was not logged in.

Should I use https://userbase.kde.org/What_is_KDE/en ?
Then translators can check if a translated page exists and decide to use en or their locale?

This is fine either (like what happens with wikipedia links); on the other side, if the redirector works, it is be a good hint for translators that don't need to check the page (and the translated version can be added later), so maybe I would use it.

This revision was automatically updated to reflect the committed changes.