Differential D11845

Make clang happy.
AbandonedPublic
Actions

Authored by adridg on Mar 31 2018, 7:43 PM.

Details

Reviewers
pali
tcberner
Group Reviewers
FreeBSD
Summary
protocols/oscar/liboscar/tasks/chatnavservicetask.cpp:106:24: note: insert an explicit cast to silence this issue
    SNAC s = { 0x000D, m_type, 0x0000, client()->snacSequence() };
                       ^~~~~~
                       static_cast<WORD>( )

Diff Detail

Repository
R434 Kopete
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
tcberner created this revision.Mar 31 2018, 7:43 PM
Restricted Application added a project: Kopete. · View Herald TranscriptMar 31 2018, 7:43 PM
Restricted Application added a subscriber: Kopete. · View Herald Transcript
tcberner requested review of this revision.Mar 31 2018, 7:43 PM
rakuco added a subscriber: rakuco.Apr 29 2018, 12:33 PM
rakuco added inline comments.
protocols/oscar/liboscar/tasks/chatnavservicetask.cpp
106

Alternatively, you can explicitly declare RequestType's underlying integer type in the header:

enum RequestType : DWORD { ... };
adridg commandeered this revision.May 30 2020, 12:19 AM
adridg added a reviewer: tcberner.
Restricted Application edited subscribers, added: kopete-devel; removed: Kopete. · View Herald TranscriptMay 30 2020, 12:19 AM
adridg abandoned this revision.May 30 2020, 12:20 AM

This was fixed independently in 114b349f09

Revision Contents
Changeset List

Diff 31062

View Options

protocols/oscar/liboscar/tasks/chatnavservicetask.cpp

Loading...