Differential D11764

Use font.weight instead of font.bold
ClosedPublic
Actions

Authored by broulik on Mar 28 2018, 7:26 AM.

Details

Reviewers
mart
hein
Group Reviewers
Plasma
Commits
R124:541598fe398a: Use font.weight instead of font.bold
Summary

font.bold is a pseudo property only forwarding to and reading from font.weight in Qt code and since the qqc2-desktop-style Label sets font.weight this seems to have precedence over our font.bold definition. I don't think that's a Kirigami but rather a Qt bug. The same happens with PlasmaComponents.Label.

Test Plan

All section headers, including the first one, are bold now

Diff Detail

Repository
R124 System Settings
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Mar 28 2018, 7:26 AM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 28 2018, 7:26 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Mar 28 2018, 7:26 AM
broulik updated this revision to Diff 30783.
  • Remove comment
hein accepted this revision.Mar 28 2018, 7:27 AM
This revision is now accepted and ready to land.Mar 28 2018, 7:27 AM
Closed by commit R124:541598fe398a: Use font.weight instead of font.bold (authored by broulik). · Explain WhyMar 28 2018, 7:33 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 30784

View Options

sidebar/package/contents/ui/CategoriesPage.qml

Loading...