[Window Rules] Fix simple shortcut not being transfered to text field
ClosedPublic
Actions

Authored by broulik on Mar 18 2016, 7:09 PM.

Details

Reviewers

luebking
graesslin

Commits

Summary

The dialog only had a "Close" button but the text was only transfered in accepted()

Also fix the position of the QDialogButtonBox which is swapped and so the buttons appear at the top.

BUG: 360521
FIXED-IN: 5.6.1

Test Plan

Works now

Repository

R108 KWin

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

broulik retitled this revision from to [Window Rules] Fix simple shortcut not being transfered to text field.

broulik updated this object.

broulik edited the test plan for this revision. (Show Details)

broulik set the repository for this revision to R108 KWin.

broulik added a project: Plasma.

graesslin edited edge metadata.

This revision is now accepted and ready to land.Mar 21 2016, 7:06 AM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			kcmkwin/kwinrules/ruleswidget.cpp (4 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	2838			Mar 18 2016, 7:08 PM	★	★
Diff 2	2872	4a05cc2	rKWINf9da3fb0eb76dc9bb66c06b745a310d09689161f	Mar 21 2016, 9:28 AM	★	★