Differential D11708

[Folder View] Fix selecting text with Shift+Home/End
ClosedPublic
Actions

Authored by broulik on Mar 26 2018, 8:16 AM.

Details

Reviewers
hein
Group Reviewers
Plasma
Commits
R119:5d719c1bb374: [Folder View] Fix selecting text with Shift+Home/End
Summary

By accepting the key event we keep the TextArea from trying to move the cursor itself potentially undoing our selection in the process.

BUG: 392318
FIXED-IN: 5.12.4

Test Plan

Home and End still move the cursor to the beginning and end, respectively, also when text wrapped into multiple lines. Ctrl+Home/End also still works
Shift+Home/End now moves selects from the cursor to the beginning or end as one would expect

Diff Detail

Repository
R119 Plasma Desktop
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik created this revision.Mar 26 2018, 8:16 AM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 26 2018, 8:16 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Mar 26 2018, 8:16 AM
broulik edited the summary of this revision. (Show Details)
broulik edited the summary of this revision. (Show Details)
hein accepted this revision.Mar 26 2018, 8:25 AM
This revision is now accepted and ready to land.Mar 26 2018, 8:25 AM
Closed by commit R119:5d719c1bb374: [Folder View] Fix selecting text with Shift+Home/End (authored by broulik). · Explain WhyMar 26 2018, 8:28 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 30604

View Options

containments/desktop/package/contents/ui/FolderView.qml

Loading...