Differential D11707

[Card] Use own "findIndex" implementation
ClosedPublic
Actions

Authored by broulik on Mar 26 2018, 7:45 AM.

Details

Reviewers
mart
hein
Group Reviewers
Plasma
Commits
R169:e7fd9e62674b: [Card] Use own "findIndex" implementation
Summary

Array.findIndex has only been added in Qt 5.9 [1]

[1] https://doc.qt.io/qt-5/qtqml-javascript-functionlist.html

Test Plan

Overflow of Cards in gallery app still works, shows only the items that are actually overflowing

Diff Detail

Repository
R169 Kirigami
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik created this revision.Mar 26 2018, 7:45 AM
Restricted Application added a project: Kirigami. · View Herald TranscriptMar 26 2018, 7:45 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Mar 26 2018, 7:45 AM
broulik updated this revision to Diff 30598.

Remove unrelated change

hein accepted this revision.Mar 26 2018, 7:56 AM
This revision is now accepted and ready to land.Mar 26 2018, 7:56 AM
hein added inline comments.Mar 26 2018, 7:59 AM
src/controls/Card.qml
107

Debug

Closed by commit R169:e7fd9e62674b: [Card] Use own "findIndex" implementation (authored by broulik). · Explain WhyMar 26 2018, 8:30 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/controls/Card.qml (15 lines)

Diff 30598

View Options

src/controls/Card.qml

Loading...