It's a little uncomfortable, that when we save cantor worksheet file with name like 'foo' and saved name also have name 'foo', because we use file filter in open file dialog and our 'foo' file will be filtered. So I have added check, that if extension for saved worksheet file don't specify, then we append it.
Details
- Reviewers
asemke - Group Reviewers
Cantor - Commits
- R55:adff6e884a48: Add worksheet extension (.cws) to name of saved file, if user haven't added it…
- Create worksheet
- Save it with name foo as Cantor worksheet
- Check that the file have name foo.cws
- Create worksheet
- Save it with name foo.cws as Cantor worksheet
- Check that the file have name foo.cws
Diff Detail
- Repository
- R55 Cantor
- Lint
Lint Skipped - Unit
Unit Tests Skipped
you don't always need to define this string. It is only needed if we save to a worksheet file and not to a plain file and no cws-extension was provided. So, simply use file_name += QLatin1String(".cws") here.
Yes, let's bring this into 18.04. More important is to bring the fixes in 62ccc7080614d8e56197c66e66625ae4f7b21b78 and 3c0251f120a13a87a21ac6abc8b53cbcfcf820f0 to 18.04 - those are show stoppers for 18.04. Albert, would you take care of this?
Can you not do that? I'm fine with commit this since Nikita doesn't have access, but you do, so you can push your commits around as necessary.
If you need help with the git commands, don't hesitate to ask.
Nikita has the access. You asked about 18.04, so I assumed you kind of managing this and I mentioned two other commits that need to go into 18.04. Anyway, I'll cherry-pick the relevant commits to the 18.04 branch.
@asemke, Only KDE developers have acces to write, isn't it? Because I think, that I not one of them, and I, as common user, have acces only for reading.
Yes, this is correct. I think I was just confused by your name in the git history and I assumed you have a kde account. Sorry.
No, it's the developers responsability to make sure the commits land in the appropiate branches
Anyway, I'll cherry-pick the relevant commits to the 18.04 branch.
Cool :)