Reworked the German holiday files
ClosedPublic
Actions

Authored by tleupold on Mar 25 2018, 1:07 PM.

Details

Reviewers

Summary

Reworked the German holiday definitions according to official sources (cf. the files)
Fixed the wording and (rewrote) the existing file for Bavaria
Added files for each federal state that has holidays in addition to the All-German ones

As said in https://bugs.kde.org/show_bug.cgi?id=373686 , imo this rework was necessary, esp. because it's not only some typos and dubious defintions in the Bavaria file (e. g. the begin of Munich's Oktoberfest), but all over the existing files. Plus, if we add Bavaria, we should do the whole thing, as there are differences in holidays for most of the federal states of Germany.

I think this should go to git master (tell me if I can "just" push it) and be part of the next release.

Diff Detail

Lint

Lint Skipped

Unit

Unit Tests Skipped

tleupold created this revision.Mar 25 2018, 1:07 PM

Restricted Application added a project: KDE PIM. · View Herald TranscriptMar 25 2018, 1:07 PM

Restricted Application added a subscriber: KDE PIM. · View Herald Transcript

tleupold requested review of this revision.Mar 25 2018, 1:07 PM

tleupold added a reviewer: winterz.

lueck added a subscriber: kde-i18n-de.Mar 25 2018, 1:26 PM

Added Nikolaus.

thanks!

This revision is now accepted and ready to land.Mar 25 2018, 8:51 PM

Thanks for the quick review! Does this now automagically go to git? Or should I push it? Sorry for asking dumb questions, but I'm pretty new to that Phabricator widget ;-)

you can push directly.
then close this phab and also close the bugs you opened regarding this problem

Please push it with arc land, which is strongly suggested way: phabricator will parse the commit message and close this review.

Also, does this review fixes https://bugs.kde.org/show_bug.cgi?id=373686 ? If yes, please edit the commit message from phabricator adding a *separate* line

BUG: nnnnnn

and that will make sure that the bug nnnnnn is closed.

Sorry, apparently, Arcanoid is currently not available yet on Gentoo (at least in the main Portage tree). So I did it manually. I added the bug so that it will be closed automatically though (at least I hope so ;-). Thanks for the support and the quick replies!

Revision Contents
Changeset List

		Path
M		holidays/holidays.qrc (11 lines)
A	M	holidays/plan2/holiday_de-bb_de (66 lines)
A	M	holidays/plan2/holiday_de-bw_de (69 lines)
M		holidays/plan2/holiday_de-by_de (108 lines)
A	M	holidays/plan2/holiday_de-hh_de (67 lines)
A	M	holidays/plan2/holiday_de-mv_de (66 lines)
A	M	holidays/plan2/holiday_de-nw_de (67 lines)
A	M	holidays/plan2/holiday_de-rp_de (67 lines)
A	M	holidays/plan2/holiday_de-sh_de (66 lines)
A	M	holidays/plan2/holiday_de-sl_de (68 lines)
A	M	holidays/plan2/holiday_de-sn_de (68 lines)
A	M	holidays/plan2/holiday_de-st_de (67 lines)
A	M	holidays/plan2/holiday_de-th_de (67 lines)
M		holidays/plan2/holiday_de_de (60 lines)