move the manageaudioplayer class to c++. with this, the main files responsible for playing audio are now in c++ only, with more to follow
Details
Details
- Reviewers
mgallien - Group Reviewers
Elisa - Commits
- R255:d41c7e060227: move manageaudio to c++
audio still plays
Diff Detail
Diff Detail
- Repository
- R255 Elisa
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
forgot to mention, I think there are opportunities to clean up afterwards, but this revision just does the direct porting of qml to c++ including the signals/slots
Comment Actions
Thanks.
I am reviewing it.
I have one question.
| src/audiowrapper.h | ||
|---|---|---|
| 117–127 | What is the rationale behind adding the property value here ? | |
| src/audiowrapper.h | ||
|---|---|---|
| 117–127 | This allows to connect the signals directly to the set functions of listening classes, and ensures that their properties are up to date. Adding the property value here is also what Qt is doing mostly, for example look at QMediaPlayer. | |
Comment Actions
Sorry for the late review. I had somehow missed your reply.
During testing, I have got the following warnings:
qrc:/qml/ElisaMainWindow.qml:137: ReferenceError: volume is not defined
qrc:/qml/ElisaMainWindow.qml:138: ReferenceError: muted is not defined