use KDE_INSTALL_DATADIR instead of FULL_DATADIR
ClosedPublic

Authored by bshah on Mar 25 2018, 11:13 AM.

Details

Summary

This is inline with other install statements

Diff Detail

Repository
R290 KPackage
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bshah created this revision.Mar 25 2018, 11:13 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptMar 25 2018, 11:13 AM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript
bshah requested review of this revision.Mar 25 2018, 11:13 AM
kossebau added a comment.EditedMar 25 2018, 11:38 AM

While myself I have never made use of it, the idea of using a relative path & not an absolute path with the DESTINATION argument is to allow overriding the install prefix at install time. Or in words of https://cmake.org/cmake/help/v3.0/command/install.html:

If a relative path is given it is interpreted relative to the value of the CMAKE_INSTALL_PREFIX variable. The prefix can be relocated at install time using the DESTDIR mechanism explained in the CMAKE_INSTALL_PREFIX variable documentation.

So given all the other install macros I have seen allow to do that, let's be consistent here and use the relative path as well. I am not aware of any need to use the absolute path here directly.

Not tested though due to broken setup currently, so just +1 and no shipit :)

kossebau accepted this revision.Apr 10 2018, 1:25 PM

If no-one else can be bothered, here my shipit.

This revision is now accepted and ready to land.Apr 10 2018, 1:25 PM
This revision was automatically updated to reflect the committed changes.