Move to KRunner's second results item with a single keypress

Authored by ngraham on Mar 23 2018, 1:38 PM.



Currently, to navigate the list of results after typing a search term, you need to press the down arrow twice: first to focus the result list, and a second time to actually change the selection. This patch fixes that by changing the selection during the focus oprtation.

BUG: 392197

Test Plan

Deployed change, killed, restarted, and activated KRunner, typed a search term:

  • The down arrow key now moves to the second item
  • Clicked on the text field; up arrow now moves to the previous item in the results list

Activating the Open Containing Folder button for the first result via the keyboard changes slightly with this patch:

  • Currently, it's down arrowtab key
  • With this patch, it's tab key three times or down arrowshift + tab

Seems like an acceptable change to me to better support the common case of just wanting to easily navigate to the results list items.

Diff Detail

R120 Plasma Workspace
fix-krunner-double-down-key-issue (branched from master)
No Linters Available
No Unit Test Coverage
ngraham created this revision.Mar 23 2018, 1:38 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 23 2018, 1:38 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Mar 23 2018, 1:38 PM
ngraham edited the test plan for this revision. (Show Details)Mar 23 2018, 1:39 PM
mart accepted this revision.Mar 23 2018, 1:53 PM
This revision is now accepted and ready to land.Mar 23 2018, 1:53 PM
broulik accepted this revision.Mar 23 2018, 2:03 PM

I guess this could go into 5.12 also

ngraham updated this revision to Diff 30319.Mar 23 2018, 2:15 PM

Also don't lose focus when there are no search results

broulik accepted this revision.Mar 23 2018, 2:15 PM
ngraham closed this revision.Mar 23 2018, 2:19 PM