Those had no transient parent set, so they got displayed somewhere, most of the
time on the wrong screen.
Also pass the actual click coordinates instead of (0,0), although those are
ignored anyway.
Details
Details
- Reviewers
davidedmundson - Group Reviewers
Plasma - Commits
- R120:cf2d64fa9718: Set a transient parent for SNI context menus
Works fine for spotify and kteatime now, but certain applications
which trigger a LayoutChanged signal on the opened event have a Y offset.
Diff Detail
Diff Detail
- Repository
- R120 Plasma Workspace
- Branch
- snitest
- Lint
No Linters Available - Unit
No Unit Test Coverage
Comment Actions
The blank line deletion should be ok, but someone should test on X11 as well. I don't expect any regressions there though.
Comment Actions
libdbusmenu-qt: Remove nonexistant actions directly from the menu
The getLayout response handler compares the new list of actions with the
current actions in the menu and calls deleteLater on all actions which aren't
part of the new list anymore.
Then, it adds all actions from the new list which aren't part of the menu yet.
As deleteLater only has an effect after the next event processing, the menu
still contains them together with the added actions.
This resulted in broken size calculations, as even for static menus the item
count changed during aboutToShow.
Note that this is not a proper solution for the resize issue, as the
aboutToShow handler changes the menus content for a reason, the application
is free to add/remove items at any point in time.
| applets/systemtray/package/contents/ui/items/StatusNotifierItem.qml | ||
|---|---|---|
| 63 ↗ | (On Diff #30245) | Why not? It is a fix for an oversight, which is currently a no-op due to another bug. |
| applets/systemtray/package/contents/ui/items/StatusNotifierItem.qml | ||
|---|---|---|
| 63 ↗ | (On Diff #30245) | I think this change is fine. Except that the MouseArea covers the entire list item, so for hidden SNIs the app might get coordinates outside of its icon. For context menu we ignore the coordinates anyway and place the menu relative to the icon (so it never covers it). For Activate the app might want to know where it was clicked. In any case this needs a bit of cleaning up, we pass parameters around in places where they're ignored and so on. |
| applets/systemtray/package/contents/ui/items/StatusNotifierItem.qml | ||
|---|---|---|
| 63 ↗ | (On Diff #30245) | I think I'll do it differently. |