Polish wording in crop ratio combobox
ClosedPublic

Authored by rkflx on Mar 22 2018, 2:25 PM.

Details

Summary

576cfa68ba01 enabled the clear button in the Crop ratio combobox.
This resulted in an even wider toolbar at the bottom, because the
combobox automatically adjusts its width to its widest entry,
potentially cutting off the toolbar at the right even more than before.

As all other entries also lack the "size" moniker, we can just drop it
for ISO size (A4, A3, …). Even the original entry before the
change in a028ea5c43af lacked "size" in the naming.

Test Plan
Open Crop tool in Advanced mode and inspect the ratio
combobox (now with consistent wording) as well as the width of the crop
toolbar (now less wide).

Diff Detail

Repository
R260 Gwenview
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
rkflx requested review of this revision.Mar 22 2018, 2:25 PM
rkflx created this revision.
ngraham accepted this revision.Mar 22 2018, 2:30 PM

Hah, looks like you and I were reviewing this feature at the same time! See also D11578: Use more user-friendly terminology in the crop tool.

+1, no need for the word "size" here; it's pretty obviously implied.

This revision is now accepted and ready to land.Mar 22 2018, 2:30 PM
This revision was automatically updated to reflect the committed changes.