Differential D11557

remove anchors of item in a layout
ClosedPublic
Actions

Authored by davidedmundson on Mar 21 2018, 6:37 PM.

Details

Reviewers
broulik
Group Reviewers
Plasma
Commits
R242:6291c4852fdf: remove anchors of item in a layout
Summary

This IconItem is in a RowLayout and has the relevant Layout.alignment
set already.

Having an anchor is undefined, and emits a warning in Qt5.11

Diff Detail

Repository
R242 Plasma Framework (Library)
Branch
origin-master (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
davidedmundson created this revision.Mar 21 2018, 6:37 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptMar 21 2018, 6:37 PM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript
davidedmundson requested review of this revision.Mar 21 2018, 6:37 PM
davidedmundson updated this revision to Diff 30147.Mar 21 2018, 6:59 PM

Add more cases

broulik accepted this revision.Mar 22 2018, 7:24 AM
This revision is now accepted and ready to land.Mar 22 2018, 7:24 AM
Closed by commit R242:6291c4852fdf: remove anchors of item in a layout (authored by davidedmundson). · Explain WhyMar 22 2018, 11:49 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 30147

View Options

src/declarativeimports/plasmastyle/ButtonStyle.qml

Loading...
View Options

src/declarativeimports/plasmastyle/ToolButtonStyle.qml

Loading...