Differential D11512

Set proper application name once browser identifies to us
ClosedPublic
Actions

Authored by broulik on Mar 20 2018, 3:43 PM.

Details

Reviewers
davidedmundson
fvogt
Commits
R856:3d8e61b3901f: Set proper application name once browser identifies to us
Summary

This information is mainly used for download progress so it shouldn't hurt if it's set quite late in the process.

BUG: 385517

Test Plan

Installed extension on chromium, verified that applicationjobs dataengine sees that now

Diff Detail

Repository
R856 Plasma Browser Integration
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Mar 20 2018, 3:43 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 20 2018, 3:43 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Mar 20 2018, 3:43 PM
davidedmundson added a comment.Mar 20 2018, 3:49 PM

We're loading all the stuff QGuiApp loads, purely for setApplicationDisplayName?

fvogt added a comment.Mar 20 2018, 4:03 PM

Wouldn't you need to set the organisationName as well?

davidedmundson accepted this revision.Mar 20 2018, 4:18 PM

+ do the thing fvogt said

This revision is now accepted and ready to land.Mar 20 2018, 4:18 PM
broulik updated this revision to Diff 30099.Mar 21 2018, 8:47 AM
  • Set organization domain and name also
fvogt accepted this revision.Mar 21 2018, 8:51 AM
Closed by commit R856:3d8e61b3901f: Set proper application name once browser identifies to us (authored by broulik). · Explain WhyMar 21 2018, 8:52 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mhost/main.cpp (4 lines)
Mhost/settings.h (15 lines)
Mhost/settings.cpp (41 lines)

Diff 30101

View Options

host/main.cpp

Loading...
View Options

host/settings.h

Loading...
View Options

host/settings.cpp

Loading...